fixup! 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation https://chromium-review.googlesource.com/c/v8/v8/+/5465511

clavin · ckerr · commit 368005f2b2f9 · 2024-05-30T22:23:36.000-05:00
diff --git a/shell/common/gin_helper/dictionary.h b/shell/common/gin_helper/dictionary.h
@@ -143,7 +143,7 @@ class Dictionary : public gin::Dictionary {
               if (gin::TryConvertToV8(info.GetIsolate(), val, &v8_value))
                 info.GetReturnValue().Set(v8_value);
             },
-            nullptr, v8_value_accessor, v8::DEFAULT, attribute)
+            nullptr, v8_value_accessor, attribute)
         .ToChecked();
   }
 

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ class Dictionary : public gin::Dictionary {`
`143`	`143`	`if (gin::TryConvertToV8(info.GetIsolate(), val, &v8_value))`
`144`	`144`	`info.GetReturnValue().Set(v8_value);`
`145`	`145`	`},`
`146`		`- nullptr, v8_value_accessor, v8::DEFAULT, attribute)`
	`146`	`+ nullptr, v8_value_accessor, attribute)`
`147`	`147`	`.ToChecked();`
`148`	`148`	`}`
`149`	`149`