test: cleanup RenderFrame lifespan tests (#47795)

trop[bot] · jkleinsc · web-flow · commit 28d8ed037c09 · 2025-07-17T12:13:27.000+02:00
* test: cleanup RenderFrame lifespan tests Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> * test: disable navigator.serial tests on arm64 mac debug the hang test: disable navigator.bluetooth on arm64 mac Revert "test: disable navigator.bluetooth on arm64 mac" This reverts commit 4b53a84. Revert "debug the hang" This reverts commit 00338f0. Revert "test: disable navigator.serial tests on arm64 mac" This reverts commit fb515ce. Reapply "test: disable navigator.serial tests on arm64 mac" This reverts commit 0e56081. Reapply "test: disable navigator.bluetooth on arm64 mac" This reverts commit f4c7d3f. fixup Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> * test: add waitUntil for flaky test Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
diff --git a/spec/api-web-frame-main-spec.ts b/spec/api-web-frame-main-spec.ts
@@ -313,6 +313,7 @@ describe('webFrameMain module', () => {
     beforeEach(async () => {
       w = new BrowserWindow({ show: false });
     });
+    afterEach(closeAllWindows);
 
     // TODO(jkleinsc) fix this flaky test on linux
     ifit(process.platform !== 'linux')('throws upon accessing properties when disposed', async () => {
@@ -373,7 +374,9 @@ describe('webFrameMain module', () => {
       await w.webContents.loadURL(server.crossOriginUrl);
       // senderFrame now points to a disposed RenderFrameHost. It should
       // be null when attempting to access the lazily evaluated property.
-      expect(event.senderFrame).to.be.null();
+      waitUntil(() => {
+        return event.senderFrame === null;
+      });
     });
 
     it('is detached when unload handler sends IPC', async () => {
diff --git a/spec/chromium-spec.ts b/spec/chromium-spec.ts
@@ -3089,7 +3089,7 @@ describe('iframe using HTML fullscreen API while window is OS-fullscreened', ()
   });
 });
 
-describe('navigator.serial', () => {
+ifdescribe(process.platform !== 'darwin' || process.arch !== 'arm64')('navigator.serial', () => {
   let w: BrowserWindow;
   before(async () => {
     w = new BrowserWindow({
@@ -3621,7 +3621,7 @@ ifdescribe((process.platform !== 'linux' || app.isUnityRunning()))('navigator.se
   });
 });
 
-describe('navigator.bluetooth', () => {
+ifdescribe(process.platform !== 'darwin' || process.arch !== 'arm64')('navigator.bluetooth', () => {
   let w: BrowserWindow;
   before(async () => {
     w = new BrowserWindow({
