Repository navigation
Commit 0dd1486
build: fail gha-done when required or checkout jobs fail (#52252)
* build: fail gha-done check when required job fails (#50959)
fix: fail gha-done when any required job failed
Previously, the `gha-done` gate job used an `if:` expression that
evaluated to false whenever any needed job reported a failure, which
caused the job to be *skipped* rather than *failed*. GitHub branch
protection treats skipped required checks as non-blocking, so a PR
could be marked mergeable even though one of its test jobs had failed.
Keep the job always running and move the failure check into a step
that explicitly exits 1 when any dependency failed or was cancelled,
so the "GitHub Actions Completed" required check actually blocks the
merge in that case.
Notes: none
* ci: fail gha-done when checkout jobs fail (#52245)
build: fail gha-done when checkout jobs fail
Claude-Session: https://claude.ai/code/session_01VR19UDbfbBMeFzWGUQehCq
Co-authored-by: Claude <[email protected]>
---------
Co-authored-by: Samuel Attard <[email protected]>
Co-authored-by: Claude <[email protected]>1 parent 4c3df5b commit 0dd1486
1 file changed
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
436 | 436 | | |
437 | 437 | | |
438 | 438 | | |
439 | | - | |
440 | | - | |
| 439 | + | |
| 440 | + | |
441 | 441 | | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
442 | 445 | | |
443 | 446 | | |
444 | 447 | | |
| |||
0 commit comments