Repository navigation
Commit 0d93097
fix: only set Node's WASM streaming callback when fetch is enabled (#… (#52240)
* fix: only set Node's WASM streaming callback when fetch is enabled (#51953)
* fix: only set Node's WASM streaming callback when fetch is enabled
Node.js v24.16.0 removed the experimental_fetch gate around
isolate->SetWasmStreamingCallback() (nodejs/node#62759). When
fix_allow_disabling_fetch_in_renderer_and_worker_processes.patch was
rebased for the version bump, the flag was restored but the gate was
not.
As a result, Node.js unconditionally overrode Blink's WebAssembly
streaming callback in renderer and worker processes, where Electron
passes --no-experimental-fetch and skips the bootstrap file that
registers Node's JS-side streaming implementation. Any call to
WebAssembly.compileStreaming() or instantiateStreaming() in a renderer
with nodeIntegration then failed the CHECK(\!impl.IsEmpty()) assertion
in node_wasm_web_api.cc and crashed the renderer.
Restore the gate so Blink's streaming callback stays in place in
processes where Node's fetch is disabled.
Fixes #51950
* test: cover WebAssembly streaming compilation in renderers with nodeIntegration
* re-export node patches
* update patches
---------
Co-authored-by: Samuel Attard <[email protected]>1 parent 35874b0 commit 0d93097
3 files changed
Lines changed: 44 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
81 | 101 | | |
82 | 102 | | |
83 | 103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
452 | 452 | | |
453 | 453 | | |
454 | 454 | | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
455 | 478 | | |
456 | 479 | | |
457 | 480 | | |
| |||
0 commit comments