Skip to content

Commit 0b3baf0

Browse files
committed
chore: fixup crypto patch rebase
1 parent 8dff7b2 commit 0b3baf0

1 file changed

Lines changed: 34 additions & 6 deletions

File tree

patches/node/fix_crypto_tests_to_run_with_bssl.patch

Lines changed: 34 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,32 @@ index 423f2c4d77bfc98bfbdab93c09aff8012c678cbd..fa0bcceb5697486930a9530732f9a9ab
2323
'308204bf020100300d06092a864886f70d0101010500048204a9308204a5020100028' +
2424
'2010100d3576092e62957364544e7e4233b7bdb293db2085122c479328546f9f0f712' +
2525
diff --git a/test/parallel/test-crypto-async-sign-verify.js b/test/parallel/test-crypto-async-sign-verify.js
26-
index 9876c4bb6ecd2e5b8879f153811cd0a0a22997aa..688ed342570741fdcc7876f375c56d3fc61c2ea1 100644
26+
index 9876c4bb6ecd2e5b8879f153811cd0a0a22997aa..2c4bf03452eb10fec52c38a361b6aad93169f08d 100644
2727
--- a/test/parallel/test-crypto-async-sign-verify.js
2828
+++ b/test/parallel/test-crypto-async-sign-verify.js
29-
@@ -113,6 +113,7 @@ test('dsa_public.pem', 'dsa_private.pem', 'sha256',
30-
// DSA w/ ieee-p1363 signature encoding
31-
test('dsa_public.pem', 'dsa_private.pem', 'sha256', false,
32-
{ dsaEncoding: 'ieee-p1363' });
29+
@@ -102,17 +102,17 @@ if (!process.features.openssl_is_boringssl) {
30+
// ECDSA w/ ieee-p1363 signature encoding
31+
test('ec_secp256k1_public.pem', 'ec_secp256k1_private.pem', 'sha384', false,
32+
{ dsaEncoding: 'ieee-p1363' });
33+
-}
34+
35+
-// DSA w/ der signature encoding
36+
-test('dsa_public.pem', 'dsa_private.pem', 'sha256',
37+
- false);
38+
-test('dsa_public.pem', 'dsa_private.pem', 'sha256',
39+
- false, { dsaEncoding: 'der' });
40+
+ // DSA w/ der signature encoding
41+
+ test('dsa_public.pem', 'dsa_private.pem', 'sha256',
42+
+ false);
43+
+ test('dsa_public.pem', 'dsa_private.pem', 'sha256',
44+
+ false, { dsaEncoding: 'der' });
45+
46+
-// DSA w/ ieee-p1363 signature encoding
47+
-test('dsa_public.pem', 'dsa_private.pem', 'sha256', false,
48+
- { dsaEncoding: 'ieee-p1363' });
49+
+ // DSA w/ ieee-p1363 signature encoding
50+
+ test('dsa_public.pem', 'dsa_private.pem', 'sha256', false,
51+
+ { dsaEncoding: 'ieee-p1363' });
3352
+}
3453

3554
// Test Parallel Execution w/ KeyObject is threadsafe in openssl3
@@ -369,9 +388,18 @@ index bd788ec4ed88289d35798b8af8c9490a68e081a2..1a5477ba928bce93320f8056db02e1a7
369388
function generateWrappingKeys() {
370389
return Promise.all(Object.keys(kWrappingData).map(async (name) => {
371390
diff --git a/test/parallel/test-x509-escaping.js b/test/parallel/test-x509-escaping.js
372-
index c8fc4abbb108a6d6849e8452d97d29187da2ebe6..e897dbbf8a69e454498f2793228e6f53ee7d54f5 100644
391+
index c8fc4abbb108a6d6849e8452d97d29187da2ebe6..825ba4c8dce775f401080a0522565bb7a087bcc3 100644
373392
--- a/test/parallel/test-x509-escaping.js
374393
+++ b/test/parallel/test-x509-escaping.js
394+
@@ -438,7 +438,7 @@ const { hasOpenSSL3 } = require('../common/crypto');
395+
const cert = fixtures.readKey('incorrect_san_correct_subject-cert.pem');
396+
397+
// The hostname is the CN, but not a SAN entry.
398+
- const servername = process.features.openssl_is_boringssl ? undefined : 'good.example.com';
399+
+ const servername = 'good.example.com';
400+
const certX509 = new X509Certificate(cert);
401+
assert.strictEqual(certX509.subject, `CN=${servername}`);
402+
assert.strictEqual(certX509.subjectAltName, 'DNS:evil.example.com');
375403
@@ -448,7 +448,7 @@ const { hasOpenSSL3 } = require('../common/crypto');
376404
assert.strictEqual(certX509.checkHost(servername, { subject: 'default' }),
377405
undefined);

0 commit comments

Comments
 (0)