You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 015e7a6
Browse filesBrowse the repository at this point in the historyBrowse files
* chore: bump node in DEPS to v24.18.0
* fix(patch): crypto tests to run with BoringSSL
Ref: nodejs/node@61b20f60a39
(cherry picked from commit 432172c)
Co-Authored-By: GPT-5.3-Codex <[email protected]>
* fix(patch): adapt ESM tests for Electron
Ref: nodejs/node@69df688fff4
Co-Authored-By: GPT-5.3-Codex <[email protected]>
(cherry picked from commit ce40736)
* test: update JWK error message assertion for unsupported algorithm
The error thrown for an unsupported OKP (Ed448) JWK changed from 'Invalid JWK data' to the more specific 'Invalid JWK OKP key'.
Ref: nodejs/node#62499
(cherry picked from commit 5718143)
* fix(patch): BoringSSL and OpenSSL incompatibilities
Ref: nodejs/node@677ca7e76c9
Co-Authored-By: GPT-5.3-Codex <[email protected]>
(cherry picked from commit 4d514ff)
* fix(patch): expose built-in electron module in ESM loader
Ref: nodejs/node@69df688fff4
Co-Authored-By: GPT-5.3-Codex <[email protected]>
* test: disable parallel/test-runner-v8-deserializer
This test synthesizes fake V8-serialized messages with the serialization format version hardcoded to 15 (0x0f). Electron bundles Chromium's V8, whose value-serializer format version is 16 (0x10), so the hardcoded headers are not recognized by the test runner's deserializer and the bytes fall through the UTF-8 stdout path (0xff -> U+FFFD), failing the assertions. The version difference is environmental and cannot be reconciled without re-patching the test on every V8 bump.
The failing subtests were introduced upstream in nodejs/node#62704 (test_runner: avoid hanging on incomplete v8 frames).
* docs: update node upgrade skill to reflect boringSSL updates
* fix(patch): skip PQC crypto tests unsupported by BoringSSL
Chromium 148's BoringSSL does not implement ML-KEM/ML-DSA/SLH-DSA, which upstream wired up for BoringSSL in nodejs/node#63255. Skip or disable the affected tests on BoringSSL for this Electron version.
Ref: nodejs/node#63255
Co-Authored-By: Claude <[email protected]>
* chore: update patches (trivial only)
* fix(patch): gate BoringSSL PQC surface on BORINGSSL_API_VERSION
Chromium 146 ships BoringSSL API version 39, which exposes the ML-DSA
and ML-KEM NIDs but not the ML-KEM EVP_PKEY_ALG accessors, the ML-KEM
encapsulate/decapsulate APIs, or EVP_PKEY_CTX_set1_signature_context_string.
Those only became available at API version 40 (Chromium 148). Gate the
BoringSSL PQC/KEM/signature-context capability macros on the API version
so the older BoringSSL builds with PQC reported as unsupported.
Ref: nodejs/node#63255
Co-Authored-By: GPT-5.3-Codex <[email protected]>
* fix(patch): skip PQC tests unsupported by 41-x-y BoringSSL
Chromium 146's BoringSSL (API v39) lacks ML-KEM and ML-DSA support, so
guard the new PQC keygen/webcrypto tests that assume BoringSSL provides
PQC (as it does on newer Chromium). Drops the boringssl PQC-enable
disjunct so these tests skip on this branch's BoringSSL.
Ref: nodejs/node#63255
Co-Authored-By: GPT-5.3-Codex <[email protected]>
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <[email protected]>
Co-authored-by: GPT-5.3-Codex <[email protected]>
Co-authored-by: Claude <[email protected]>
Copy file name to clipboardExpand all lines: .claude/skills/electron-node-upgrade/SKILL.md
+41-14Lines changed: 41 additions & 14 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -228,21 +228,48 @@ Electron runs a subset of Node.js's upstream test suite using a custom runner (`
228
228
229
229
### BoringSSL incompatibilities
230
230
231
-
Electron uses BoringSSL (via Chromium) instead of OpenSSL. Many crypto features are missing or behave differently:
231
+
Electron builds Node.js against Chromium's BoringSSL instead of Node.js's bundled OpenSSL. As of the v24.18.0 roll this is wired up through a GN arg rather than large source patches:
# Build Node.js against Chromium's BoringSSL instead of node's bundled OpenSSL.
236
+
node_openssl_path = "//third_party/boringssl"
237
+
```
238
+
239
+
Upstream Node.js now supports building against BoringSSL natively (see nodejs/node commits `677ca7e76c9` and `61b20f60a39`), so most of Electron's historical BoringSSL workarounds have been **eliminated**. During the v24.18.0 roll:
240
+
241
+
- `fix_crypto_tests_to_run_with_bssl.patch` shrank from ~1100 lines to skipping just two test files.
242
+
- `fix_handle_boringssl_and_openssl_incompatibilities.patch` dropped ~176 lines. What remains is C++-level shimming in `deps/ncrypto/ncrypto.cc`, `src/crypto/crypto_{common,context,hash}.cc`, `src/env.h`, `src/node_metadata.h`, and `src/node_options.h`.
243
+
244
+
Expect to **delete** these workarounds over time rather than grow them. Only add a guard when a feature is genuinely still missing from BoringSSL; upstream tests increasingly self-skip when `process.features.openssl_is_boringssl` is set, so no Electron change is needed.
245
+
246
+
**Preferred guard for a still-unsupported feature** — skip the whole test file at the top, and add it to `fix_crypto_tests_to_run_with_bssl.patch`:
**Behavioral differences (assertion updates, not skips)** — some errors just changed shape:
242
269
243
-
When guarding tests, prefer checking cipher availability (`ciphers.includes(algo)`) over blanket BoringSSL checks where possible, as it's more precise and self-documenting.
270
+
- Creating a private key from an unsupported OKP (Ed448) JWK now throws `Invalid JWK OKP key` (previously `Invalid JWK data`); see nodejs/node#62499. Electron's `spec/node-spec.ts` assertion was loosened to `/Invalid JWK/`.
244
271
245
-
New upstream tests that exercise these features will need guards added to the `fix_crypto_tests_to_run_with_bssl` patch.
272
+
When you do need to guard a test, prefer a precise capability check (e.g. `ciphers.includes('aes-128-ccm')`) over a blanket `process.features.openssl_is_boringssl` check where the feature can be probed directly.
246
273
247
274
### Snapshot test mismatches
248
275
@@ -300,8 +327,8 @@ Only add a test to `script/node-disabled-tests.json` as a **last resort** — wh
300
327
301
328
These patches consistently require the most work during Node.js upgrades:
302
329
303
-
- **`fix_handle_boringssl_and_openssl_incompatibilities.patch`** — Electron uses BoringSSL (via Chromium) while Node.js expects OpenSSL. This patch is large and complex, and upstream OpenSSL API changes frequently break it.
304
-
- **`fix_crypto_tests_to_run_with_bssl.patch`** — Companion to the above; adapts Node.js crypto tests for BoringSSL. Can grow significantly during major upgrades.
330
+
- **`fix_handle_boringssl_and_openssl_incompatibilities.patch`** — Electron uses BoringSSL (via Chromium) while Node.js expects OpenSSL. Historically large and complex, this patch was **greatly reduced** once Node.js gained native BoringSSL support (enabled via `node_openssl_path = "//third_party/boringssl"`in`build/args/all.gn`). It still shims some C++-level differences, and upstream OpenSSL/ncrypto API changes canbreak it.
331
+
- **`fix_crypto_tests_to_run_with_bssl.patch`** — Companion to the above; adapts Node.js crypto tests for BoringSSL. Also **greatly reduced** now that upstream tests self-skip under BoringSSL — it mainly skips a handful of still-unsupported test files. See the "BoringSSL incompatibilities" section above.
305
332
- **`support_v8_sandboxed_pointers.patch`** — V8 sandbox pointer support requires careful adaptation when V8 APIs change.
306
333
- **`build_add_gn_build_files.patch`** — The GN build file patch is large and touches many build targets. Upstream build system changes frequently conflict.
0 commit comments