Skip to content

Commit 044a295

Browse files
authored
[performance](Planner): optimize getStringValue() in DateLiteral (apache#27363)
- reduce cost of `getStringValue()` - original code don't consider `microsecond` part in `getStringValue()`
1 parent 1b3512d commit 044a295

1 file changed

Lines changed: 45 additions & 11 deletions

File tree

‎fe/fe-core/src/main/java/org/apache/doris/analysis/DateLiteral.java‎

Lines changed: 45 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,14 @@
6767

6868
public class DateLiteral extends LiteralExpr {
6969
private static final Logger LOG = LogManager.getLogger(DateLiteral.class);
70+
private static final double[] SCALE_FACTORS;
71+
72+
static {
73+
SCALE_FACTORS = new double[7];
74+
for (int i = 0; i < SCALE_FACTORS.length; i++) {
75+
SCALE_FACTORS[i] = Math.pow(10, 6 - i);
76+
}
77+
}
7078

7179
private static final DateLiteral MIN_DATE = new DateLiteral(0000, 1, 1);
7280
private static final DateLiteral MAX_DATE = new DateLiteral(9999, 12, 31);
@@ -596,23 +604,49 @@ public String toSqlImpl() {
596604
return "'" + getStringValue() + "'";
597605
}
598606

607+
private void fillPaddedValue(char[] buffer, int start, long value, int length) {
608+
int end = start + length;
609+
for (int i = end - 1; i >= start; i--) {
610+
buffer[i] = (char) ('0' + value % 10);
611+
value /= 10;
612+
}
613+
}
614+
599615
@Override
600616
public String getStringValue() {
617+
char[] dateTimeChars = new char[26]; // Enough to hold "YYYY-MM-DD HH:MM:SS.mmmmmm"
618+
619+
// Populate the date part
620+
fillPaddedValue(dateTimeChars, 0, year, 4);
621+
dateTimeChars[4] = '-';
622+
fillPaddedValue(dateTimeChars, 5, month, 2);
623+
dateTimeChars[7] = '-';
624+
fillPaddedValue(dateTimeChars, 8, day, 2);
625+
601626
if (type.isDate() || type.isDateV2()) {
602-
return String.format("%04d-%02d-%02d", year, month, day);
603-
} else if (type.isDatetimeV2()) {
627+
return new String(dateTimeChars, 0, 10);
628+
}
629+
630+
// Populate the time part
631+
dateTimeChars[10] = ' ';
632+
fillPaddedValue(dateTimeChars, 11, hour, 2);
633+
dateTimeChars[13] = ':';
634+
fillPaddedValue(dateTimeChars, 14, minute, 2);
635+
dateTimeChars[16] = ':';
636+
fillPaddedValue(dateTimeChars, 17, second, 2);
637+
638+
if (type.isDatetimeV2()) {
604639
int scale = ((ScalarType) type).getScalarScale();
605-
long ms = Double.valueOf(microsecond / (int) (Math.pow(10, 6 - ((ScalarType) type).getScalarScale()))
606-
* (Math.pow(10, 6 - ((ScalarType) type).getScalarScale()))).longValue();
607-
String tmp = String.format("%04d-%02d-%02d %02d:%02d:%02d",
608-
year, month, day, hour, minute, second);
609-
if (ms == 0) {
610-
return tmp;
640+
long scaledMicroseconds = (long) (microsecond / SCALE_FACTORS[scale]);
641+
642+
if (scaledMicroseconds != 0) {
643+
dateTimeChars[19] = '.';
644+
fillPaddedValue(dateTimeChars, 20, (int) scaledMicroseconds, scale);
645+
return new String(dateTimeChars, 0, 20 + scale);
611646
}
612-
return tmp + String.format(".%06d", ms).substring(0, scale + 1);
613-
} else {
614-
return String.format("%04d-%02d-%02d %02d:%02d:%02d", year, month, day, hour, minute, second);
615647
}
648+
649+
return new String(dateTimeChars, 0, 19);
616650
}
617651

618652
@Override

0 commit comments

Comments
 (0)