[ML] Upgrade to Boost 1.86.0 on ARM macOS#2779
Merged
edsavage merged 28 commits intoelastic:mainfrom Dec 3, 2024
Merged
Conversation
From version 9.0.0 we drop support for macos x86_64 builds. Therefore all support for cross compiling for macos x86_64 has also been dropped. Builds have been migrated to be executed solely on macos 13 (Ventura) aarch64. In CI, these builds are performed on updated Orka VMs. In addition, 3rd part dependencies (boost, pytorch) are now baked into the Orka VM, so downloading these dependencies at run time is no longer required,
Update build scripts, docs and license information to refer to Boost 1.86.0
Also a couple of compilation/test fixes
Contributor
Author
|
buildkite build this |
valeriy42
approved these changes
Nov 28, 2024
Comment on lines
+1290
to
+1295
| // Interestingly we used to assert extraMem > 0 here as it used to be the case | ||
| // that once a boost::small_vector had switched | ||
| // off of internal storage it would NEVER go back to internal storage. | ||
| // Arguably that was a bug, and this assertion started failing after | ||
| // upgrading Boost to 1.86.0, meaning that boost::small_vector has been improved. | ||
| BOOST_TEST_REQUIRE(extraMem >= 0); // Change to `==` once upgraded to Boost 1.86 on all platforms |
Contributor
|
Cmake cannot find the new boost in the build. The new orka image seems to contain the old version of Boost. |
|
edsavage
added a commit
to edsavage/ml-cpp
that referenced
this pull request
Dec 6, 2024
Update build scripts, docs and license information to refer to Boost 1.86.0 Follow up to elastic#2774
edsavage
added a commit
that referenced
this pull request
Dec 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update build scripts, docs and license information to refer to Boost 1.86.0
Depends on #2774