5.5 backport of windows build/test fixes#8354
Merged
colinsurprenant merged 6 commits intoelastic:5.5from Sep 21, 2017
Merged
Conversation
use rm_rf to delete dir and shutdown pipeline after run avoid the use of rescue nil, bad practice do not mock close as it prevents closing the file an prevents removing it on Windows cleanup temporary files and relax file name check for Windows fix paths handling for Windows flag the read file string as UTF-8 which is what we expect fix Windows issues ignore load_average on windows windows safe URI cleanup and fix file handling for windows wait for pipeline shutdown to complete revert to original puts cleanups use environment for windows platform check fix hash path wait for pipeline thread to complete after shutdown
colinsurprenant
changed the title
Contributor
|
LGTM (once Jenkins also approves) |
fixes fix jvm.options parsing windows compatible URI adjust launch bat scripts to new logic adjust .bat lauch scripts
Addresses elastic#7637 Fixes elastic#7716 Fixes elastic#7717
colinsurprenant
force-pushed
the
5.5
branch
from
be2f679 to
a9a144a
Compare
Contributor
Author
|
merged in 5.5 and created a v5.5.4 label as it will only apply to this future release if it is (very unlikely) ever built. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes for windows build/tests compatibility for 5.5 branch.
also fixes the windows launch scripts to pick up
jvm.optionsrelates to #8125 and #7767