Bug fix: Fix Ruby loggers by fixing log4j2 setup#8339
Closed
jakelandis wants to merge 1 commit intoelastic:5.6from
Closed
Bug fix: Fix Ruby loggers by fixing log4j2 setup#8339jakelandis wants to merge 1 commit intoelastic:5.6from
jakelandis wants to merge 1 commit intoelastic:5.6from
Conversation
Contributor
Author
Contributor
|
LGTM moving forward, in master I'd like to see if we can find a way to build that |
colinsurprenant
approved these changes
Sep 20, 2017
|
Jake Landis merged this into the following branches!
|
elasticsearch-bot
pushed a commit
that referenced
this pull request
Sep 20, 2017
This was referenced Sep 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this may have been a bad merge. I just copied the exact code from master, and all is well. (I didn't test from Windows)
Note - this issue is only present on the 5.6 branch