Windows build fixes for 5.6#8125
Conversation
|
@colinsurprenant - sorry for the delay. Was able to run to success locally. Great job tracking these down. LGTM
|
colinsurprenant
force-pushed
the
fix/56_windows_build
branch
from
f9a13e8 to
c67a55e
Compare
|
rebased to ignore the UTF-8 commit since this was already patched by the new launch scripts PR #8178 |
colinsurprenant
force-pushed
the
fix/56_windows_build
branch
from
c67a55e to
e241744
Compare
|
I rebased against 5.6 and hopefully the build will pass - the last build had problems and I am not sure how much was related if any. |
|
@colinsurprenant - the new Jenkins Docker builds aren't quite stable yet, and may get an artificial failure. However, these Windows tests aren't active yet in the Jenkins build. See the checkbox item "Fix false positive success from ci\ci_test.bat" #7767 (The file is acutally ci\unit_tests.bat now). I am pretty certain that only the Java unit tests are actually running. We will need to fix the long file name issue first before we can enable these tests in ci. |
|
@jakelandis yeah I know - but I do want to make sure none of my changes have negatively impacted the Linux builds too so that's why I am hoping for a green build. |
colinsurprenant
force-pushed
the
fix/56_windows_build
branch
from
e241744 to
e3a1678
Compare
|
waiting to see if rebasing to include #8339 will help this build. |
|
ok, only failure is the integration test failures on |
|
WDYT @jakelandis @ph ? ^^ |
|
I've looked at the job logs and I can see a lot of failures related to |
|
@colinsurprenant - I think that is a transient error do to an overloaded host. I kicked it off again in Travis to be sure. FWIW, the same tests are run in Jenkins are passing. |
|
WOOT thanks @jakelandis @ph - will now merge. 😅 |
colinsurprenant
force-pushed
the
fix/56_windows_build
branch
from
e3a1678 to
2eff1fd
Compare
use rm_rf to delete dir and shutdown pipeline after run avoid the use of rescue nil, bad practice do not mock close as it prevents closing the file an prevents removing it on Windows cleanup temporary files and relax file name check for Windows fix paths handling for Windows flag the read file string as UTF-8 which is what we expect fix Windows issues ignore load_average on windows windows safe URI cleanup and fix file handling for windows wait for pipeline shutdown to complete revert to original puts cleanups use environment for windows platform check fix hash path wait for pipeline thread to complete after shutdown
colinsurprenant
force-pushed
the
fix/56_windows_build
branch
from
2eff1fd to
19ad0ef
Compare
3 participants
Backport of #8116 for 5.6 and added 5.6 windows specific fixes.
Included here is the addition of
-Dfile.encoding=UTF-8in theJVM_OPTSinsetup.batas a stop-gap until #8126 is fixed.