force UTF-8 encoding for gem file reading#8068
Merged
colinsurprenant merged 1 commit intoelastic:masterfrom Aug 25, 2017
Merged
force UTF-8 encoding for gem file reading#8068colinsurprenant merged 1 commit intoelastic:masterfrom
colinsurprenant merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
@colinsurprenant - Great find! LGTM |
jakelandis
approved these changes
Aug 24, 2017
Contributor
Author
|
non related integration test failure, reported in #8073 |
colinsurprenant
force-pushed
the
fix/7768
branch
from
fe7a561 to
67c2d9a
Compare
Contributor
Author
|
merged in master, 6.x, 6.0 and 5.6. |
colinsurprenant
added
v5.6.0
v6.0.0
v6.0.0-beta2
v6.1.0
v7.0.0-alpha1
and removed
v6.1.0
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7768
Under Windows, the read string encoding was set to
Windows-1252which was breaking theDSLinstance_evalon that string.It is probably worth exploring if that encoding problem is actually a JRuby specific bug and report it if it is. The fact that there is no exception when doing the
instance_evalbut instead the object becomes invalid is certainly a bug worth digging and reporting.tested on OSX for regression and Windows where previously the plugins installation would fail and now correctly works.