Skip to content

[APM] Make 'opamp_polling_interval' and 'sampling_rate' agent config vars available to EDOT Node.js#241048

Merged
trentm merged 2 commits into
elastic:mainfrom
trentm:trentm-edot-nodejs-moar-central-config-vars
Oct 30, 2025
Merged

[APM] Make 'opamp_polling_interval' and 'sampling_rate' agent config vars available to EDOT Node.js#241048
trentm merged 2 commits into
elastic:mainfrom
trentm:trentm-edot-nodejs-moar-central-config-vars

Conversation

@trentm

@trentm trentm commented Oct 29, 2025

Copy link
Copy Markdown
Member

Refs: elastic/elastic-otel-node#960
Refs: elastic/elastic-otel-node#1128

Summary

This makes two more central-config settings available to EDOT Node.js SDK/agents.
An earlier equivalent PR was: #233798

@trentm trentm self-assigned this Oct 29, 2025
@trentm trentm added release_note:enhancement backport:skip This PR does not require backporting Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Oct 29, 2025
@trentm
trentm marked this pull request as ready for review October 29, 2025 15:20
@trentm
trentm requested a review from a team October 29, 2025 15:20
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine

Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #62 / serverless search UI - search features Search Playground - Saved Playgrounds Update Saved Playground should allow updating playground name

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +62.0B

cc @trentm

@cauemarcondes cauemarcondes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trentm
trentm merged commit 432f385 into elastic:main Oct 30, 2025
13 checks passed
@trentm
trentm deleted the trentm-edot-nodejs-moar-central-config-vars branch October 30, 2025 00:09
ana-davydova pushed a commit to ana-davydova/kibana that referenced this pull request Nov 3, 2025
…vars available to EDOT Node.js (elastic#241048)

This makes two more central-config settings available to EDOT Node.js
SDK/agents.

Refs: elastic/elastic-otel-node#960
Refs: elastic/elastic-otel-node#1128
SergeyKleyman added a commit that referenced this pull request Nov 5, 2025
#241908)

Ref: PR elastic/elastic-otel-php#296 implements handling of
`sampling_rate` central config option on the EDOT PHP side

## Summary

This makes one more central-config setting available to EDOT PHP
SDK/agents.
An earlier equivalent PR was: #241048

---------

Co-authored-by: kibanamachine <[email protected]>
wildemat pushed a commit to wildemat/kibana that referenced this pull request Nov 5, 2025
elastic#241908)

Ref: PR elastic/elastic-otel-php#296 implements handling of
`sampling_rate` central config option on the EDOT PHP side

## Summary

This makes one more central-config setting available to EDOT PHP
SDK/agents.
An earlier equivalent PR was: elastic#241048

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:enhancement Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants