Skip to content

[Fleet] Migrate all usages of EuiPage*_Deprecated #161418

Closed

Description

@cee-chen

👋 Hello from your friendly neighborhood EUI team! It's been almost a year since EUI's new EuiPageTemplate came out (if you can believe it), which means we're about a month away from the old deprecated EUI page template components being permanently removed.

Your team is being pinged in this issue because you have 2 usages of EuiPage*_Deprecated components, which you can find listed here:

https://github.com/search?q=repo%3Aelastic%2Fkibana+%2FEuiPage%5Ba-zA-Z%5D%2B_Deprecated%2F+path%3A%2F%5Ex-pack%5C%2Fplugins%5C%2Ffleet%2F&type=code

How

  • Please see our new EuiPageTemplate guidelines and examples for suggestions on how to migrate over.
  • You can also see more examples of layout conversions in the original EuiPageTemplate PR:
    [Feature] EuiPage and EuiPageTemplate Updates eui#5768
  • Here's a quick conversion map of components that approximately translate to their new equivalents:
    • EuiPageTemplate_Deprecated -> EuiPageTemplate
    • EuiPageSideBar_Deprecated -> EuiPageSidebar or EuiPageTemplate.Sidebar
    • EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
    • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
    • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead
    • EuiPageContentHeaderSection_Deprecated -> Use EuiPageHeader instead

When

We'd really appreciate it if you could migrate your component usages over before or during August if possible.

If your team does not have the ability or bandwidth to perform this work by that time, please let us know. While we'd really appreciate as many teams as possible taking on this work so we're not having to touch hundreds of files by ourselves and in one go, the EUI team can potentially help you out - but we will need you to help QA that work and ensure your layouts look the same as before.

Thanks, and please feel free to reach out anytime with questions or help with migration!

Activity

  1. elasticmachine commented on Jul 7, 2023

    @elasticmachine
    Contributor

    Pinging @elastic/fleet (Team:Fleet)

  2. elasticmachine commented on Jul 7, 2023

    @elasticmachine
    Contributor

    Pinging @elastic/eui-team (EUI)

  3. jlind23 commented on Jul 17, 2023

    @jlind23
    Contributor

    @juliaElastic @criamico do we still rely on any deprecated Eui component?

  4. juliaElastic commented on Jul 17, 2023

    @juliaElastic
    Contributor

    Checked the usages, and found only 2 of them. Should be a small effort to fix.

    EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
    https://github.com/search?q=repo%3Aelastic%2Fkibana+EuiPageContent_Deprecated+path%3Ax-pack%2Fplugins%2Ffleet&type=code

  5. criamico commented on Jul 18, 2023

    @criamico
    Member

    I'm looking into it, it should be a very quick PR

  6. self-assigned this
    on Jul 18, 2023
  7. cee-chen commented on Jul 24, 2023

    @cee-chen
    ContributorAuthor

    🎉 Huge thanks for jumping on this so quickly - y'all rock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions