Enable optimizedText for CBOR#132542
Merged
felixbarny merged 13 commits intoelastic:mainfrom Aug 8, 2025
Merged
Conversation
felixbarny
added
:Core/Infra/Core
elasticsearchmachine
added
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Contributor
jordan-powers
left a comment
jordan-powers
left a comment
There was a problem hiding this comment.
The outline looks good, but I think there are a couple of bugs related to the parser state. We want to avoid disrupting the parser so that it still works as normal even after calling getValueAsText().
libs/x-content/impl/src/main/java/org/elasticsearch/xcontent/provider/cbor/ESCborParser.java
Outdated
Show resolved
Hide resolved
...x-content/impl/src/test/java/org/elasticsearch/xcontent/provider/cbor/ESCborParserTests.java
Outdated
Show resolved
Hide resolved
Doesn't need to decode, just counts the number of characters while iterating over the utf8-encoded bytes.
Member
Author
|
Good catch, thanks! |
jordan-powers
approved these changes
Aug 8, 2025
Contributor
jordan-powers
left a comment
jordan-powers
left a comment
There was a problem hiding this comment.
LGTM, thanks Felix!
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.