Skip to content

Fix knn search error when dimensions are not set#131081

Merged
carlosdelest merged 5 commits intoelastic:mainfrom
carlosdelest:tests/knn-fix-search-with-no-dimensions
Jul 11, 2025
Merged

Fix knn search error when dimensions are not set#131081
carlosdelest merged 5 commits intoelastic:mainfrom
carlosdelest:tests/knn-fix-search-with-no-dimensions

Conversation

@carlosdelest
Copy link
Member

@carlosdelest carlosdelest commented Jul 11, 2025

A KNN search that uses similarity when no dimensions are set for a dense_vector field caused a NPE when calculating similarity:

            if (similarityThreshold != null) {
                knnQuery = new VectorSimilarityQuery(
                    knnQuery,
                    similarityThreshold,
                    similarity.score(similarityThreshold, elementType, dims)
                );
            }

Having no dimensions set on a dense_vector field means that no data has been ingested yet, so we can shortcut to use a MatchNoDocsQuery in this case.

Closes #129550

@carlosdelest carlosdelest added >bug auto-backport Automatically create backport pull requests when merged :Search Relevance/Vectors Vector search v8.9.1 v8.9.2 Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.19.0 v8.18.5 labels Jul 11, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jul 11, 2025

Hi @carlosdelest, I've created a changelog YAML for you.

@carlosdelest carlosdelest mentioned this pull request Jul 11, 2025
Closed
@carlosdelest carlosdelest marked this pull request as ready for review July 11, 2025 13:25
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jul 11, 2025

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@carlosdelest carlosdelest requested a review from a team July 11, 2025 14:05
john-wagster
john-wagster approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@carlosdelest carlosdelest merged commit bbc4cef into elastic:main Jul 11, 2025
33 checks passed
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jul 11, 2025

💔 Backport failed

Status Branch Result
❌ 8.9 Commit could not be cherrypicked due to conflicts
❌ 8.19 Commit could not be cherrypicked due to conflicts
❌ 8.18 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 131081

@carlosdelest carlosdelest mentioned this pull request Jul 11, 2025
Merged
carlosdelest added a commit to carlosdelest/elasticsearch that referenced this pull request Jul 11, 2025
@carlosdelest
Fix knn search error when dimensions are not set (elastic#131081)
ea957b8 
* Unmute tests muted in elastic#129550 as they were fixed in elastic#127322

* Return no match when no dimensions have been set

* Add tests

* Update docs/changelog/131081.yaml

(cherry picked from commit bbc4cef)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java
#	x-pack/plugin/esql/qa/testFixtures/src/main/resources/knn-function.csv-spec
@carlosdelest carlosdelest mentioned this pull request Jul 11, 2025
Merged
carlosdelest added a commit to carlosdelest/elasticsearch that referenced this pull request Jul 11, 2025
@carlosdelest
Fix knn search error when dimensions are not set (elastic#131081)
cc45de8 
* Unmute tests muted in elastic#129550 as they were fixed in elastic#127322

* Return no match when no dimensions have been set

* Add tests

* Update docs/changelog/131081.yaml

(cherry picked from commit bbc4cef)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java
#	server/src/main/java/org/elasticsearch/search/SearchFeatures.java
#	x-pack/plugin/esql/qa/testFixtures/src/main/resources/knn-function.csv-spec
@carlosdelest carlosdelest mentioned this pull request Jul 11, 2025
Merged
carlosdelest added a commit to carlosdelest/elasticsearch that referenced this pull request Jul 11, 2025
@carlosdelest
Fix knn search error when dimensions are not set (elastic#131081)
0e75627 
* Unmute tests muted in elastic#129550 as they were fixed in elastic#127322

* Return no match when no dimensions have been set

* Add tests

* Update docs/changelog/131081.yaml

(cherry picked from commit bbc4cef)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java
#	server/src/main/java/org/elasticsearch/search/SearchFeatures.java
#	x-pack/plugin/esql/qa/testFixtures/src/main/resources/knn-function.csv-spec
@carlosdelest carlosdelest mentioned this pull request Jul 11, 2025
Merged
@carlosdelest
Copy link
Member Author

carlosdelest commented Jul 11, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.1
✅ 9.0
✅ 8.19
✅ 8.18

Questions ?

Please refer to the Backport tool documentation

carlosdelest added a commit to carlosdelest/elasticsearch that referenced this pull request Jul 11, 2025
@carlosdelest
Fix knn search error when dimensions are not set (elastic#131081)
648b3b8 
* Unmute tests muted in elastic#129550 as they were fixed in elastic#127322

* Return no match when no dimensions have been set

* Add tests

* Update docs/changelog/131081.yaml

(cherry picked from commit bbc4cef)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java
#	server/src/main/java/org/elasticsearch/search/SearchFeatures.java
#	x-pack/plugin/esql/qa/testFixtures/src/main/resources/knn-function.csv-spec
carlosdelest added a commit that referenced this pull request Jul 11, 2025
@carlosdelest
Fix knn search error when dimensions are not set (#131081) (#131122)
c3b3793
carlosdelest added a commit that referenced this pull request Jul 11, 2025
@carlosdelest
Fix knn search error when dimensions are not set (#131081) (#131119)
b5b77da
elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2025
@carlosdelest
Fix knn search error when dimensions are not set (#131081) (#131118)
c53d73d 
* Unmute tests muted in #129550 as they were fixed in #127322

* Return no match when no dimensions have been set

* Add tests

* Update docs/changelog/131081.yaml

(cherry picked from commit bbc4cef)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java
#	x-pack/plugin/esql/qa/testFixtures/src/main/resources/knn-function.csv-spec
elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2025
@carlosdelest
Fix knn search error when dimensions are not set (#131081) (#131120)
df80e2e 
* Unmute tests muted in #129550 as they were fixed in #127322

* Return no match when no dimensions have been set

* Add tests

* Update docs/changelog/131081.yaml

(cherry picked from commit bbc4cef)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java
#	server/src/main/java/org/elasticsearch/search/SearchFeatures.java
#	x-pack/plugin/esql/qa/testFixtures/src/main/resources/knn-function.csv-spec
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
@carlosdelest @mridula-s109
Fix knn search error when dimensions are not set (elastic#131081)
20e0d2b 
* Unmute tests muted in elastic#129550 as they were fixed in elastic#127322

* Return no match when no dimensions have been set

* Add tests

* Update docs/changelog/131081.yaml
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
@carlosdelest @mridula-s109
Fix knn search error when dimensions are not set (elastic#131081)
2cad879 
* Unmute tests muted in elastic#129550 as they were fixed in elastic#127322

* Return no match when no dimensions have been set

* Add tests

* Update docs/changelog/131081.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benwtrent benwtrent benwtrent approved these changes

@john-wagster john-wagster john-wagster approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged backport pending >bug :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.9.1 v8.9.2 v8.18.5 v8.19.0 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ESQL: partial failure in few KNN tests

4 participants

@carlosdelest @elasticsearchmachine @benwtrent @john-wagster

Comments