ESQL: Assert no partial results in integration tests#129293
Merged
bpintea merged 5 commits intoelastic:mainfrom Jun 17, 2025
Merged
ESQL: Assert no partial results in integration tests#129293bpintea merged 5 commits intoelastic:mainfrom
bpintea merged 5 commits intoelastic:mainfrom
Conversation
This injects assertions in spec-based and YAML integration tests that the received results aren't partial. This only happens in case the tests themselves don't set `"allow_partial_results": true`
bpintea
added
>test
nik9000
approved these changes
Jun 12, 2025
| Map<String, Object> answer = runEsql(builder.query(query), testCase.assertWarnings(deduplicateExactWarnings())); | ||
|
|
||
| var isPartial = answer.get("is_partial"); | ||
| assertTrue("unexpected partial results", isPartial == null || (boolean) isPartial == false); |
Member
There was a problem hiding this comment.
Might be easier to read with assertThat(..., anyOf(is(false), nullValue())). Dunno. Your call.
Contributor
Author
There was a problem hiding this comment.
Yes, better, thanks.
| var apiCallSection = doSection.getApiCallSection(); | ||
| if (apiCallSection.getApi().equals("esql.query")) { | ||
| // If `allow_partial_results` is explicitly set to true, partial results are allowed. | ||
| // If it's missing, no partial results are expected, even if the parameter's default is true. |
Member
There was a problem hiding this comment.
It's a bit of magic, I think it's a pretty reasonable sacrifice.
dnhatn
approved these changes
Jun 12, 2025
|
|
||
| var isPartial = answer.get("is_partial"); | ||
| assertTrue("unexpected partial results", isPartial == null || (boolean) isPartial == false); | ||
|
|
Member
There was a problem hiding this comment.
nit: can we also extract the failures and throw them?
Contributor
Author
There was a problem hiding this comment.
Good idea, I've extracted _clusters contents into the assertion message (we don't have more otherwise).
Contributor
Author
The changes apply to those suites too. |
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
bpintea
added
the
auto-backport
Contributor
Author
|
Thanks Nik and Nhat. |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 30, 2025
This extends the check that no partial results are returned to the rest of the JSON-based REST ITs. Related: #129293
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Jun 30, 2025
…0213) This extends the check that no partial results are returned to the rest of the JSON-based REST ITs. Related: elastic#129293
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 30, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 30, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
…0213) This extends the check that no partial results are returned to the rest of the JSON-based REST ITs. Related: elastic#129293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This injects assertions in spec-based and YAML integration tests that the received results aren't partial.
This only happens in case the tests themselves don't set
"allow_partial_results": true.Closes #129256