Improve TestBuildInfoPluginFuncTest#128322
Merged
prdoyle merged 9 commits intoelastic:mainfrom May 23, 2025
Merged
Conversation
prdoyle
added
>test
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Contributor
Author
|
Hopefully #128316 does the trick. |
Contributor
Author
Contributor
Author
|
Latest failure is fixed upstream I think. |
Contributor
Author
|
Hmm, maybe not. |
Contributor
Author
|
Aha, I had not set this PR to auto-merge. |
Turns out even on Windows, jar entries use forward slashes. Let's be consistent in all cases.
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
May 23, 2025
* Use walkFileTree for extractModuleNameFromDirectory * More tests in TestBuildInfoPluginFuncTest * Remove stray line from debugging * [CI] Auto commit changes from spotless * Eliminate List.reversed() call --------- Co-authored-by: elasticsearchmachine <[email protected]>
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 23, 2025
* Improve TestBuildInfoPluginFuncTest (#128322) * Use walkFileTree for extractModuleNameFromDirectory * More tests in TestBuildInfoPluginFuncTest * Remove stray line from debugging * [CI] Auto commit changes from spotless * Eliminate List.reversed() call --------- Co-authored-by: elasticsearchmachine <[email protected]> * Fix the Text class package change in example plugins (#128316) --------- Co-authored-by: elasticsearchmachine <[email protected]> Co-authored-by: Lorenzo Dematté <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractModuleNameFromDirectoryto callwalkFileTreeTestBuildInfoPluginFuncTest