Implement OpAMP remote config parsing and vendor customizations (#272)#381
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR extends the Elastic OpenTelemetry PHP extension to parse and apply remote configuration delivered via OpAMP. Native C++ code in 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@elastic_prod/native/libelastic/ElasticConfigProvider.cpp`:
- Around line 144-145: There is a duplicate assignment to
result[STRINGIFY_HELPER(OTEL_PHP_LOG_LEVEL)] in ElasticConfigProvider.cpp;
replace the redundant second assignment so it assigns the intended variant
(e.g., STRINGIFY_HELPER(OTEL_PHP_LOG_LEVEL_STDERR) or the appropriate
_STDERR/_SYSLOG/_FILE variant consistent with the subsequent lines) instead of
overwriting the same key; update the line that currently duplicates
STRINGIFY_HELPER(OTEL_PHP_LOG_LEVEL) to use the correct target key while keeping
the value loglevel and leaving the surrounding result[...] assignments
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 8a3bda56-a2e1-41a9-b948-b915cebba9ba
📒 Files selected for processing (7)
elastic_prod/native/libelastic/ElasticConfigProvider.cppelastic_prod/native/libelastic/ElasticConfigProvider.helastic_prod/native/libelastic/ElasticVendor.cppelastic_prod/native/libelastic/ElasticVendor.helastic_prod/native/libelastic/elastic_vendor_inject.cmakeelastic_prod/php/Elastic/OTel/OpAmp/ElasticRemoteConfigParser.phpupstream
2 participants
ElasticConfigProvider(logging_level,infer_spans,opamp_polling_interval) with level translation and duration unit handlingElasticVendor::setLogger()andgetAdditionalResourceAttributes()ElasticRemoteConfigParser: class aliasing, native-side option handling, relative log path, all log level sinks mappedupdated upstream adding improved OpAMP remote config handling