Skip to content

Use opentelemetry-php-distro v0.4.0 as base for EDOT#377

Merged
intuibase merged 3 commits into
elastic:mainfrom
intuibase:use_distro_0.4.0
May 6, 2026
Merged

Use opentelemetry-php-distro v0.4.0 as base for EDOT#377
intuibase merged 3 commits into
elastic:mainfrom
intuibase:use_distro_0.4.0

Conversation

@intuibase

@intuibase intuibase commented May 5, 2026

Copy link
Copy Markdown
Contributor

Update upstream submodule to opentelemetry-php-distro 0.4.0 and align EDOT PHP accordingly.

Changes

Upstream (opentelemetry-php-distro 0.4.0):

  • Enabled support for PHP 8.5 (#58) (PR #77)
  • Added user bootstrap config option (PR #76)
  • Automate C++ semconv header generation during CMake configure (#63) (PR #75)
  • Update Laravel instrumentation to 1.7.0 (PR #65)
  • Update SDK and instrumentation modules (PR #62)
  • fix: selection of PHP version in component test docker image (PR #61)
  • Switch native build to new docker image (PR #79)

EDOT PHP changes:

  • Updated upstream submodule to 0.4.0 (fa8f77b)
  • Added PHP 8.5 to supported versions in post-install.sh
  • Updated documentation (supported PHP versions 8.1–8.5, Laravel 6.x–13.x, library versions for Curl/MySQLi/PDO)
  • Updated native build docker image tag (conancache-v0.0.2)

@coderabbitai

coderabbitai Bot commented May 5, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The CoordinatorProcess.cpp implementation was removed, deleting the coordinator loop, periodic parent-liveness and abandoned-message cleanup tasks, message-receive processing, and enqueue error handling. The Docker build image tag in tools/build/build_native.sh was updated from conancache-v0.0.1 to conancache-v0.0.2. The upstream submodule pointer was advanced to a new commit SHA. Documentation in docs/reference/edot-php/supported-technologies.md expanded PHP support to 8.1–8.5, added Laravel 6.x–13.x, and adjusted library version ranges; packaging/scripts/post-install.sh was updated to recognize PHP 8.5.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@intuibase
intuibase requested a review from a team as a code owner May 6, 2026 09:29
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

🔍 Preview links for changed docs

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

✅ Vale Linting Results

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/reference/edot-php/supported-technologies.md`:
- Line 73: Update the documented Laravel version range string that currently
reads "Laravel `6.x` to `13.x`" to correctly state "Laravel `6.x` to `12.x`";
locate the exact occurrence of the text "Laravel `6.x` to `13.x`" in the
supported-technologies content (the documented Laravel range) and replace `13.x`
with `12.x` so the docs match the upstream
open-telemetry/opentelemetry-auto-laravel supported versions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 9423b976-52cb-4ec9-851f-c5f2b036bae6

📥 Commits

Reviewing files that changed from the base of the PR and between 14c24dc and 82ab0f3.

📒 Files selected for processing (2)
  • docs/reference/edot-php/supported-technologies.md
  • packaging/scripts/post-install.sh

Comment thread docs/reference/edot-php/supported-technologies.md
@intuibase
intuibase requested a review from alexandra5000 May 6, 2026 09:34
@intuibase
intuibase merged commit 2d4f451 into elastic:main May 6, 2026
68 checks passed
@intuibase
intuibase deleted the use_distro_0.4.0 branch May 6, 2026 13:57
@intuibase intuibase self-assigned this May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants