Propagate upstream PHP dependency NOTICE to EDOT NOTICE (#375)#376
Conversation
📝 WalkthroughWalkthroughThe NOTICE file is updated to remove third-party package entries and their embedded license text blocks for seven dependencies, leaving only the Apache 2.0 project license header. In parallel, the build script 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tools/build/build_php_deps.sh`:
- Around line 18-31: The wrapper currently consumes --skip_notice in parse_args
(setting SKIP_NOTICE) but still forwards the original "$@" to the upstream
script, leaking the wrapper-only flag; update parse_args to build a filtered
argument list (e.g., an array like FILTERED_ARGS) by pushing only non-wrapper
flags into it, keep SKIP_NOTICE as-is, and change the downstream invocation to
use the filtered arguments (use FILTERED_ARGS instead of "$@") so parse_args,
SKIP_NOTICE and the upstream call no longer forward --skip_notice.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 361338c9-e053-494b-a0a6-c1e3b48ec8f9
📒 Files selected for processing (2)
NOTICEtools/build/build_php_deps.sh
💤 Files with no reviewable changes (1)
- NOTICE
2 participants
No description provided.