OpAMP PHP side (the part applying remote options to OTel SDK)#236
Merged
Conversation
SergeyKleyman
marked this pull request as ready for review
July 7, 2025 07:03
intuibase
reviewed
Jul 8, 2025
| continue; | ||
| } | ||
|
|
||
| if (putenv($envVarName . '=' . $remoteOptVal)) { |
Contributor
There was a problem hiding this comment.
Remote config should be translated to "otel" values before applying.
I think we can implement something like filename->translator map and then add elastic specific translations.
Please take a look into native part PR for log level translation
intuibase
approved these changes
Jul 28, 2025
intuibase
added a commit
that referenced
this pull request
Jul 28, 2025
* OpAMP http client #194 (#211) * OpAmp protocol library * HttpAsyncTransport allows reading response * Semantic conventions for native part * Basic resource detector * Fixed clang-format defs * Updated conan repository URL * Elastic dynamic configuration adapter for handling config changes on native side * OpAMP PHP side (the part applying remote options to OTel SDK) (#236) --------- Co-authored-by: Sergey Kleyman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #195