Added infra/basic component tests#120
Merged
SergeyKleyman merged 39 commits intoFeb 13, 2025
Merged
Conversation
Generating list of the supported PHP versions by reading from ./elastic-otel-php.properties
Adapted TransactionSpanTest to changes in "Removed HTTP related attributes from transaction span for CLI script"
SergeyKleyman
marked this pull request as ready for review
February 12, 2025 14:01
intuibase
reviewed
Feb 13, 2025
intuibase
left a comment
intuibase
left a comment
Contributor
There was a problem hiding this comment.
generally looks good, PR contains a lot of code from elastic-apm - at some point I assumed that it works because it is very difficult to track all of those files responsibilities.
I'm a bit worries about Config/* - I'm not sure if you tracked PR's I was creating when I was working on native part - it's not 100% compatible with elastic-apm.
intuibase
self-requested a review
February 13, 2025 16:27
intuibase
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98