Summary
After rebasing EDOT PHP on the upstream opentelemetry-php-distro submodule, the build_php_deps.sh wrapper needs to propagate upstream-generated NOTICE content (PHP dependency licenses) into the EDOT NOTICE file.
Changes
Update tools/build/build_php_deps.sh to:
- Parse
--skip_notice flag (matching upstream's interface) while passing all arguments through to upstream unchanged
- After upstream build completes, append the upstream
NOTICE file content to the EDOT root NOTICE
- Skip NOTICE propagation when
--skip_notice is passed
The upstream build_php_deps.sh generates PHP dependency license information (via notice_generator.php running in Docker) and appends it to upstream/NOTICE. The EDOT wrapper captures this and appends it to the top-level NOTICE file, which has the Elastic copyright header.
Summary
After rebasing EDOT PHP on the upstream
opentelemetry-php-distrosubmodule, thebuild_php_deps.shwrapper needs to propagate upstream-generated NOTICE content (PHP dependency licenses) into the EDOTNOTICEfile.Changes
Update
tools/build/build_php_deps.shto:--skip_noticeflag (matching upstream's interface) while passing all arguments through to upstream unchangedNOTICEfile content to the EDOT rootNOTICE--skip_noticeis passedThe upstream
build_php_deps.shgenerates PHP dependency license information (vianotice_generator.phprunning in Docker) and appends it toupstream/NOTICE. The EDOT wrapper captures this and appends it to the top-levelNOTICEfile, which has the Elastic copyright header.