Workaround for temporality configuration not being possible#610
Merged
Conversation
SylvainJuge
previously approved these changes
Apr 16, 2025
SylvainJuge
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just after releasing, I discovered that the temporality setting
otel.exporter.otlp.metrics.temporality.preferencehad no more effect. The temporality would always be cumulative, independent of what is configured. Even our changed default to delta did not take effect.This was introduced in #593 due to a bug in the
toBuilder()implementation in the exporters:open-telemetry/opentelemetry-java#7276
I've added more integrationish test reproducing the problem and added a workaround. I've also manually verified the fix.