Add support for OpenAI client 0.22 to 0.31#564
Conversation
SylvainJuge
left a comment
SylvainJuge
left a comment
There was a problem hiding this comment.
LGTM, are those methods already covered by existing tests ?
Also, not directly related but should we think about adding the base version of the target library in the instrumentation module name to align with upstream ? I vaguely remember we already talked about it but don't recall what the conclusion was.
Wasn't this just about the package names? We added the supported base versions there.
Our instrumented methods are, yes. The ones we don't instrument are not, but the proxying mechanism itself is tested. |
codefromthecrypt
left a comment
codefromthecrypt
left a comment
There was a problem hiding this comment.
Thanks for the continued drift management!
3 participants
These versions
Exceptionfrom theclose()signature, which fortunately for us is a bytecode-backwards compatible changeI don't think we need to check and add those new methods to our instrumentation now, we should revisit when the OpenAI client is out of beta. Currently there are almost weekly releases changing things, which would just cause too much of an overhead for us.