Add support for OpenAI client 0.13.0#514
Merged
Merged
Conversation
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
openai-bump
branch
from
January 23, 2025 05:18
aa7fd0a to
56879d9
Compare
codefromthecrypt
marked this pull request as ready for review
January 23, 2025 05:20
anuraaga
approved these changes
Jan 23, 2025
| .stopOfStrings(Collections.singletonList("foo")) | ||
| .seed(100L) | ||
| .responseFormat(ResponseFormatText.builder().type(ResponseFormatText.Type.TEXT).build()) | ||
| .responseFormat(ResponseFormatText.builder().build()) |
Contributor
There was a problem hiding this comment.
Heh - yeah saw the comment on the issue this looks like it'll change again
Contributor
Author
|
verified the example by running it with the agent attached to this workflow run |
Contributor
Author
|
So, we need to merge and release this ASAP since users who choose latest openai java will fail to get traces, and our examples fail to compile in the latest version, too. Once this is merged and released, we need to merge this https://github.com/elastic/observability-labs/pull/320 |
JonasKunz
approved these changes
Jan 23, 2025
JonasKunz
left a comment
JonasKunz
left a comment
Contributor
There was a problem hiding this comment.
LGTM, manually verified that the instrumentation is still functional with older OpenAI client versions.
SylvainJuge
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes in the API are in the latest 0.13.0 version from this issue
Notes:
type()->_type()was an intentional change