add stop-sending option#474
Conversation
jackshirazi
changed the title
| private Boolean recoverySendMetricsState; | ||
|
|
||
| private boolean initSendingStates() { | ||
| if (recoverySendSpansState == null && ElasticSpanExporter.getInstance() != null) { |
There was a problem hiding this comment.
Should we log warning if the exporter instances are null here? This means that the setting might not be correctly respected initially, right?
| @AfterEach | ||
| public void endTest() throws InterruptedException { | ||
| doRequest(getUrl("/dynamicconfig/reset"), okResponseBody("reset")); | ||
| Thread.sleep(500L); // give the reset time to be applied |
There was a problem hiding this comment.
Is there a reason for using the smoke-tests instead of an integration-test ?
I prefer the integration tests because they are easier to follow, debug and maintain and still run the full agent.
There was a problem hiding this comment.
there was a reason which is that I prefer the smoke tests and find the integration tests non-transparent in how they work. Though I take your point they are easier to maintain. And these tests are actually integration testst. I've done an initial pass and found a bug the integration test identified that the smoke tests didn't, so I'll map them over
There was a problem hiding this comment.
per discussion (the integration test is unable to handle the exporter wrapping correctly because it has a custom exporter that doesn't go through configuration), staying with the smoke test
4 participants
No description provided.