Advance RFC 0049 (entity store) to stage 2 #2537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This advanced RFC 0049 to stage 2, and adds entity fields to the ECS schema as beta fields.
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
@mjwolf did you try altering the subsets file to allow this? I'm pretty sure that's how we allow the complex nested re-use ie client.user.group. I think you just need to add entity to the user.target section https://github.com/elastic/ecs/blob/main/schemas/subsets/main.yml#L600 |
Using the subsets file, add entity under target, for the fieldsets which use this. For `host`, entity is not nested under target, as it doesn't have this field. This matches the requirments of the RFC.
mjwolf
force-pushed
the
rfc-0049-stage2
branch
from
50c963b to
85d733d
Compare
mjwolf
force-pushed
the
rfc-0049-stage2
branch
from
c502759 to
68e8f31
Compare
kgeller
approved these changes
Sep 26, 2025
mjwolf
added a commit
to mjwolf/ecs
that referenced
this pull request
Sep 26, 2025
Advance RFC 0049 (entity store) to stage 2
mjwolf
added a commit
that referenced
this pull request
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What does this PR do?
This advanced RFC 0049 to stage 2, and adds entity fields to the ECS schema as beta fields.
2. Which ECS fields are affected/introduced?
This adds new
entityfields as beta, and modifies host, user, cloud and service fieldset by adding entity fields to them through re-use.3. Why is this change necessary?
This advanced RFC 0049 through the RFC process, and makes the entity fields part of the ECS schema, which will unlock use cases using these fields.
4. Have you added/updated documentation?
YES
5. Have you built ECS and committed any newly generated files?
YES
6. Have you run the ECS validation tests locally?
YES
7. Anything else for the reviewers?
Commit Message
Advance RFC 0049 (entity store) to stage 2