Skip to content

Fix privileged flag #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tacklebox merged 4 commits into from
Jun 29, 2023
Merged

Fix privileged flag #2225

Tacklebox merged 4 commits into from
Jun 29, 2023

Conversation

@Tacklebox
Copy link
Contributor

@Tacklebox Tacklebox commented Jun 27, 2023

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • Have you added an entry to the CHANGELOG.next.md?

@Tacklebox Tacklebox self-assigned this Jun 27, 2023
@Tacklebox Tacklebox requested a review from a team as a code owner June 27, 2023 15:18
@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Documentation changes preview: https://ecs_2225.docs-preview.app.elstc.co/diff

ebeahan
ebeahan approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Let's also capture this PR in the changelog entry.

Otherwise, LGTM!

Tacklebox and others added 4 commits June 29, 2023 15:21
@Tacklebox
Move container.privileged to container.security_context.privileged
a46e879 
I did not rebase correctly to resolve conflicts in the previous PR and merged the incorrect initial path to the privileged flag
@Tacklebox
Regenerate Artifacts
3ff2902
@Tacklebox
Update changelog
313cc22
@Tacklebox @ebeahan
Update CHANGELOG.next.md
4207f77 
Co-authored-by: Eric Beahan <[email protected]>
@Tacklebox Tacklebox force-pushed the mborden/container.security_context.privileged branch from 882d952 to 4207f77 Compare June 29, 2023 13:21
ChrsMark
ChrsMark approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change lgtm in high level.

mmat11
mmat11 approved these changes Jun 29, 2023
View reviewed changes
Copy link

@mmat11 mmat11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Tacklebox Tacklebox merged commit 8af589c into main Jun 29, 2023
@ebeahan ebeahan mentioned this pull request Aug 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebeahan ebeahan ebeahan approved these changes

@ChrsMark ChrsMark ChrsMark approved these changes

@norrietaylor norrietaylor Awaiting requested review from norrietaylor

+1 more reviewer

@mmat11 mmat11 mmat11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Tacklebox Tacklebox

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Tacklebox @ebeahan @mmat11 @ChrsMark