TBS: Fix incorrectly large pebble database lsm_size monitoring metric#17149
Merged
carsonip merged 2 commits intoelastic:mainfrom Jun 9, 2025
Merged
TBS: Fix incorrectly large pebble database lsm_size monitoring metric#17149carsonip merged 2 commits intoelastic:mainfrom
carsonip merged 2 commits intoelastic:mainfrom
Conversation
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
carsonip
changed the title
2 tasks
carsonip
changed the title
isaacaflores2
approved these changes
Jun 9, 2025
kruskall
approved these changes
Jun 9, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
…#17149) Fix negative lsm size in monitoring metric by bumping pebble to include upstream bugfix. This should stop occasional database storage limit exceeded errors due to negative lsm_size overflowed to a large int. (cherry picked from commit b6d397d) # Conflicts: # NOTICE-fips.txt # NOTICE.txt # go.mod # go.sum
mergify bot
added a commit
that referenced
this pull request
Jun 9, 2025
…m_size monitoring metric (#17153) * TBS: Fix incorrectly large pebble database lsm_size monitoring metric (#17149) Fix negative lsm size in monitoring metric by bumping pebble to include upstream bugfix. This should stop occasional database storage limit exceeded errors due to negative lsm_size overflowed to a large int. (cherry picked from commit b6d397d) # Conflicts: # NOTICE-fips.txt # NOTICE.txt # go.mod # go.sum * Fix merge conflict --------- Co-authored-by: Carson Ip <[email protected]> Co-authored-by: Carson Ip <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Fix negative lsm size in monitoring metric by bumping pebble to include upstream bugfix. This should stop occasional database storage limit exceeded errors due to negative lsm_size overflowed to a large int.
Checklist
- [ ] Update CHANGELOG.asciidocto be done on releaseFor functional changes, consider:
How to test these changes
Run apmbench / apmsoak against a TBS-enabled apm-server and observe that the lsm_size is not unrealistically large.
On a side note, I've used the setup to reproduce the bug and confirmed it is fixed.
Related issues
Fixes #17043