fix: clear duration display after meta command execution#75
Merged
Conversation
Previously, the duration from the last R command persisted in the prompt after executing meta commands like :restart, :help, :cd. Now the duration is cleared whenever a meta command is processed. Co-Authored-By: Claude Opus 4.6 <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR fixes a prompt UX issue where the {duration} segment (showing the previous R command’s execution time) could incorrectly persist after executing REPL meta commands (e.g., :help, :restart).
Changes:
- Added
PromptRuntimeConfig::clear_command_duration()to reset stored command duration. - Invoked duration clearing after meta command processing in both the standalone REPL loop and the main R
ReadConsoleloop.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/arf-console/src/repl/state.rs | Adds a runtime-config helper to clear stored last-command duration so {duration} won’t render stale values. |
| crates/arf-console/src/repl/mod.rs | Calls the new helper after meta command handling in both REPL input paths to prevent stale duration display. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:restart,:help,:cd, etc.) no longer leave the previous R command's duration in the promptclear_command_duration()method and call it in both REPL loops when a meta command is processedBefore:
After:
Test plan
Sys.sleep(2), confirm2sappears in prompt:help, confirm duration is cleared:restart(cancel withn), confirm duration is cleared🤖 Generated with Claude Code