fix(headless): address review feedback on history persistence#135
Merged
fix(headless): address review feedback on history persistence#135
Conversation
- Warn when set_headless_history is called more than once instead of silently ignoring the duplicate - Skip whitespace-only commands in headless history (Evaluate and UserInput paths) to match REPL behavior - Fix doc comment in test that incorrectly mentioned start_timestamp verification Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Verify that whitespace-only strings sent via evaluate and user_input are not persisted to the history database. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR refines headless-mode history persistence behavior to better match the REPL and addresses prior review feedback related to history recording and test documentation.
Changes:
- Emit a warning (instead of silently ignoring) when
set_headless_historyis called more than once. - Skip persisting whitespace-only commands to headless history for both IPC
evaluateanduser_inputpaths. - Update the headless history persistence test to remove an incorrect mention of
start_timestampverification and add assertions for whitespace-only command skipping.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/arf-console/tests/headless_tests.rs | Updates test documentation and adds coverage ensuring whitespace-only commands are not persisted. |
| crates/arf-console/src/ipc/mod.rs | Warns on duplicate headless history initialization and filters whitespace-only commands before saving history. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_headless_historyis called more than once instead of silently ignoring the duplicatestart_timestampverificationAddresses review feedback from Copilot on PR #134.
Test plan
cargo fmt --checkpassescargo clippy --workspacepassescargo test -p arf-console(requires R runtime)🤖 Generated with Claude Code