This repository was archived by the owner on Sep 1, 2025. It is now read-only.
ClickHouse Module#6
Closed
enqueue wants to merge 4 commits intoei-grad:clickhouse_driverfrom
enqueue:clickhouse_module
Closed
ClickHouse Module#6enqueue wants to merge 4 commits intoei-grad:clickhouse_driverfrom enqueue:clickhouse_module
enqueue wants to merge 4 commits intoei-grad:clickhouse_driverfrom
enqueue:clickhouse_module
Conversation
Author
|
Hi @ei-grad Could you perhaps review and merge the PR? Since all the tests are passing, we will hopefully have a better chance to bring the driver into the official master. |
Author
|
Hi @ei-grad sorry to bother you with this, but it would be nice if we could move the Metabase ClickHouse driver forward a little bit... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happy New Year 2019 to you!
ClickHouse driver will probably end up as a module. I refactored the PR to bring the driver into this structure. I also made a change to make prepared statement date parameters work better. All tests are green now 🎉 I am using an artificial alias to cope with ClickHouse speciality. It is a bit of a hack, but I did not see a better way.
Have you used the driver, yet?