issue-3034 : correcting OccupiedBytes statistic value at heap tier#3062
Closed
nishchay-naresh wants to merge 1 commit intoehcache:masterfrom
Closed
issue-3034 : correcting OccupiedBytes statistic value at heap tier#3062nishchay-naresh wants to merge 1 commit intoehcache:masterfrom
nishchay-naresh wants to merge 1 commit intoehcache:masterfrom
Conversation
nishchay-naresh
requested review from
AbfrmBlr,
chrisdennis and
jhouserizer
GaryWKeim
reviewed
Sep 23, 2022
...c/test/java/org/ehcache/impl/internal/store/heap/bytesized/OnHeapStoreByteStatisticTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/ehcache/impl/internal/store/heap/bytesized/OnHeapStoreByteStatisticTest.java
Outdated
Show resolved
Hide resolved
chrisdennis
requested changes
Sep 29, 2022
ehcache-impl/src/main/java/org/ehcache/impl/internal/store/heap/SimpleBackend.java
Outdated
Show resolved
Hide resolved
chrisdennis
reviewed
Oct 31, 2022
ehcache-impl/src/main/java/org/ehcache/impl/internal/store/heap/SimpleBackend.java
Outdated
Show resolved
Hide resolved
chrisdennis
reviewed
Oct 31, 2022
ehcache-impl/src/main/java/org/ehcache/impl/internal/store/heap/SimpleBackend.java
Show resolved
Hide resolved
chrisdennis
reviewed
Oct 31, 2022
ehcache-impl/src/main/java/org/ehcache/impl/internal/store/heap/SimpleBackend.java
Show resolved
Hide resolved
chrisdennis
reviewed
Oct 31, 2022
ehcache-impl/src/main/java/org/ehcache/impl/internal/store/heap/SimpleBackend.java
Outdated
Show resolved
Hide resolved
nishchay-naresh
force-pushed
the
issue-3034
branch
from
82583aa to
cd3ec47
Compare
chrisdennis
requested changes
Nov 3, 2022
| import static org.hamcrest.MatcherAssert.assertThat; | ||
| import static org.hamcrest.Matchers.*; | ||
|
|
||
| public class OnHeapStoreByteSizeTest { |
Member
There was a problem hiding this comment.
This test needs an @BeforeClass assumption to prevent it failing under Java 17. You can test this by running:
./gradlew -PtestVM=${JAVA_HOME_17} test
ehcache-impl/src/main/java/org/ehcache/impl/internal/store/heap/OnHeapStore.java
Show resolved
Hide resolved
chrisdennis
approved these changes
Nov 4, 2022
chrisdennis
requested changes
Nov 4, 2022
Member
chrisdennis
left a comment
chrisdennis
left a comment
There was a problem hiding this comment.
Needs rebasing against the commit that introduced the bug... then we're good to go.
nishchay-naresh
force-pushed
the
issue-3034
branch
from
539b6de to
60688df
Compare
Contributor
Author
|
opened another PR for daggy fix and get it merged, closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.