fix: scope package resolve logic in monorepo#20
Merged
fengmk2 merged 1 commit intoeggjs:masterfrom Jan 12, 2024
anson09:master
Merged
fix: scope package resolve logic in monorepo#20fengmk2 merged 1 commit intoeggjs:masterfrom anson09:master
fengmk2 merged 1 commit intoeggjs:masterfrom
anson09:master
Conversation
|
Someone is attempting to deploy a commit to the no-veronica Team on Vercel. A member of the Team first needs to authorize it. |
fengmk2
pushed a commit
that referenced
this pull request
Jan 12, 2024
[skip ci] ## [3.0.1](v3.0.0...v3.0.1) (2024-01-12) ### Bug Fixes * scope package resolve logic in monorepo ([#20](#20)) ([f4a47b9](f4a47b9))
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When frameworkName is like @ali/egg, globalModuleDir will resolve a result like xxx/@ali/. After that do path.join with frameworkName, we get xxx/@ali/@ali/egg, it's an error path.
So, we need to fix the resolving logic for the scoped package situation