fix: serverTimeout default to 0 (no timeout) (#5325)

fengmk2 · web-flow · commit 44ab507b6299 · 2024-06-07T12:03:46.000+08:00
typo fix on onProtoPoisoning, should be 400 response


&lt;!-- This is an auto-generated comment: release notes by coderabbit.ai
--&gt;

## Summary by CodeRabbit

- **Bug Fixes**
- Updated the response code for `Prototype-Poisoning` from `403` to
`400`.

- **Configuration Changes**
  - Changed the default server timeout setting to 0 (no timeout).

&lt;!-- end of auto-generated comment: release notes by coderabbit.ai --&gt;
diff --git a/config/config.default.js b/config/config.default.js
@@ -359,7 +359,7 @@ module.exports = appInfo => {
   config.workerStartTimeout = 10 * 60 * 1000;
 
   /**
-   * server timeout in milliseconds, default to 2 minutes.
+   * server timeout in milliseconds, default to 0 (no timeout).
    *
    * for special request, just use `ctx.req.setTimeout(ms)`
    *
diff --git a/index.d.ts b/index.d.ts
@@ -330,7 +330,7 @@ declare module 'egg' {
      * @property {Number} queryString.parameterLimit - parameter number limit, default 1000
      * @property {String[]} enableTypes - parser will only parse when request type hits enableTypes, default is ['json', 'form']
      * @property {Object} extendTypes - support extend types
-     * @property {String} onProtoPoisoning - Defines what action must take when parsing a JSON object with `__proto__`. Possible values are `'error'`, `'remove'` and `'ignore'`. Default is `'error'`, it will return `403` response when `Prototype-Poisoning` happen.
+     * @property {String} onProtoPoisoning - Defines what action must take when parsing a JSON object with `__proto__`. Possible values are `'error'`, `'remove'` and `'ignore'`. Default is `'error'`, it will return `400` response when `Prototype-Poisoning` happen.
      */
     bodyParser: {
       enable: boolean;
@@ -352,7 +352,7 @@ declare module 'egg' {
         form: string[];
         text: string[];
       };
-      /** Default is `'error'`, it will return `403` response when `Prototype-Poisoning` happen. */
+      /** Default is `'error'`, it will return `400` response when `Prototype-Poisoning` happen. */
       onProtoPoisoning: 'error' | 'remove' | 'ignore';
     };
 
@@ -532,7 +532,7 @@ declare module 'egg' {
     onClientError(err: Error, socket: Socket, app: EggApplication): ClientErrorResponse | Promise<ClientErrorResponse>;
 
     /**
-     * server timeout in milliseconds, default to 2 minutes.
+     * server timeout in milliseconds, default to 0 (no timeout).
      *
      * for special request, just use `ctx.req.setTimeout(ms)`
      *

Original file line number	Diff line number	Diff line change
`@@ -359,7 +359,7 @@ module.exports = appInfo => {`
`359`	`359`	`config.workerStartTimeout = 10 * 60 * 1000;`
`360`	`360`
`361`	`361`	`/**`
`362`		`- * server timeout in milliseconds, default to 2 minutes.`
	`362`	`+ * server timeout in milliseconds, default to 0 (no timeout).`
`363`	`363`	`*`
`364`	`364`	* for special request, just use `ctx.req.setTimeout(ms)`
`365`	`365`	`*`