Repository navigation
feat(providers): guiar la conexión de cuentas adicionales - #47
Merged
Merged
Conversation
Preserve save diagnostics, prevent concurrent save/login races and distinguish credential-file presence from session validity. Refs #46
egdev6
marked this pull request as ready for review
October 10, 2026 10:25
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue vinculada
Closes #46
Tipo
type:feature).Resumen
Cambios
src/Settings.tsxsrc/lib/account-login.tssrc/lib/account-login.test.tssrc/lib/settings-save.tssrc/lib/settings-save.test.tssrc/lib/api.tsaccount_session.src-tauri/src/lib.rssrc/theme.cssdocs/account-onboarding.md9 archivos, +389/−20 frente a
main: una unidad funcional de onboarding con pruebas y documentación. No se cambia el refresco OAuth, secretos, dependencias ni infraestructura de release.Test plan
Comprobaciones repetidas por un verificador independiente sobre el resultado final:
npm test: 154 Vitest + 46 Node, sin fallos.npm run build: TypeScript y Vite correctos.cargo test --offline --lockedensrc-tauri: 51 Rust, sin fallos.git diff --checklimpio.LSP: 7 archivos consultados, 2 confirmados limpios y 5 inconclusos. TypeScript/build y compilación/tests Rust pasan; cero diagnósticos recibidos no prueba limpieza de los cinco inconclusos. Shellcheck no aplica (sin scripts shell modificados).
Evaluación y riesgos
ASSESS inicialmente no pudo evaluar los archivos nuevos sin rastrear. Tras el staging normal autorizado para este commit, la evaluación nativa sí resolvió: riesgo medio,
reviewDue: false(under_budget), perfil de writer grande; no requiere otro verificador y ya se realizó verificación independiente. No equivale a aprobación/cierre de revisión nativa.Riesgo residual: coordinación asíncrona del guardado y contrato compartido de Ajustes. Los tests y la sonda no validan autenticación real ni comportamiento nativo en Windows. El PR queda borrador, sin merge ni release.
Checklist
status:approved.type:featuresolicitada al crear el PR.Co-Authored-By.