Repository navigation
fix(templates): bind native authorization to fixed-template bytes - #53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR type
type:bugChanges
skills/github-repository-bootstrap/scripts/bootstrap.mjsskills/github-repository-bootstrap/scripts/fixed-template-state.mjsskills/github-repository-bootstrap/tests/fixed-template-renderer.test.mjsskills/github-repository-bootstrap/tests/helpers/native-cli-fixtures.mjsdocs/odd/b01-fixed-template-state.mdReview scope: 5 paths, 372 additions / 24 deletions = 396 combined lines.
Validation
Meaningful native CLI RED with bootstrap unwired: 15 tests, 8 passed / 7 behavior failures; all six delivered tests passed. Initial wired 14/15 exposed an incorrect expected skipped-label record in the late partial-report test. The complete expected record was corrected without removing assertions; focused GREEN is 15/15.
Local Node 24/Linux checks:
LSP limitation: one primary active batch returned 0 diagnostics, 0 confirmed-clean files and 4 inconclusive checks. The human explicitly accepted this limitation for this candidate; it is not successful semantic type checking. Native assessment was unassessable due untracked declaration, so high-risk self-verification plus a separate independent verifier were performed; native approval did not replace functional checks.
Hosted Node 20/Windows/macOS results are pending CI, not inferred from Linux. The new source-file symlink test explicitly skips Windows; the two inherited descriptor/procfs skips remain separate. Metadata capture now reads assets even in ensure mode and rejects non-regular sources/destinations: not a behavior-neutral refactor. Batch capture does not eliminate later races, aliases, source-read races or provide global rollback. The trusted offline fixture is not a sandbox.
Contributor checklist
type:bug).Linked issue
Refs #15
This unit does not complete or close #15. Remaining runtime modules, offline #15/live #17 acceptance, protection/migration and independent API candidate #49 remain separate. No merge, auto-merge, release, Root synchronization or cleanup requested.