feat: add manifest logo with dark mode display condition#582
Merged
eemeli merged 4 commits intoeemeli:mainfrom Oct 9, 2024
Merged
feat: add manifest logo with dark mode display condition#582eemeli merged 4 commits intoeemeli:mainfrom
eemeli merged 4 commits intoeemeli:mainfrom
Conversation
Owner
|
Hi! Could you file this PR in eemeli/yaml-docs instead? That's where the image needs to go. Note also that GitHub's readme rendering is really limited, and e.g. selecting an image based on the light/dark mode is not possible. This means that you'll need to pick one image to use. |
Contributor
Author
|
@eemeli I have added the logo in svg format to the yaml-docs repo. So I updated the file here by replacing the png logo by a svg one, with a white background. So that we call only one logo for manifest. |
Owner
|
Thank you! This one's much better in dark mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the logos :
We need theme to be added to
https://eemeli.org/yaml/images/repo.