fix: Carriage return in tag shorthand (#501)

eemeli · eemeli · commit 4af74194f5e6 · 2023-11-02T18:36:02.000-07:00
diff --git a/src/doc/directives.ts b/src/doc/directives.ts
@@ -143,7 +143,7 @@ export class Directives {
       return verbatim
     }
 
-    const [, handle, suffix] = source.match(/^(.*!)([^!]*)$/) as string[]
+    const [, handle, suffix] = source.match(/^(.*!)([^!]*)$/s) as string[]
     if (!suffix) onError(`The ${source} tag has no suffix`)
     const prefix = this.tags[handle]
     if (prefix) {
diff --git a/tests/doc/types.ts b/tests/doc/types.ts
@@ -112,6 +112,12 @@ describe('tags', () => {
       expect(doc.errors).toHaveLength(1)
       expect(doc.errors[0].message).toMatch('URIError')
     })
+
+    test('CR in tag shorthand (eemeli/yaml#501', () => {
+      const doc = parseDocument(': | !\r!')
+      const err = doc.errors.find(err => err.code === 'TAG_RESOLVE_FAILED')
+      expect(err).not.toBeFalsy()
+    })
   })
 
   test('eemeli/yaml#97', () => {

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ export class Directives {`
`143`	`143`	`return verbatim`
`144`	`144`	`}`
`145`	`145`
`146`		`- const [, handle, suffix] = source.match(/^(.!)([^!])$/) as string[]`
	`146`	`+ const [, handle, suffix] = source.match(/^(.!)([^!])$/s) as string[]`
`147`	`147`	if (!suffix) onError(`The ${source} tag has no suffix`)
`148`	`148`	`const prefix = this.tags[handle]`
`149`	`149`	`if (prefix) {`