Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.44%. Comparing base (af09b21) to head (806323e).
⚠️ Report is 84 commits behind head on main.

@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   86.72%   85.44%   -1.28%     
==========================================
  Files          11       11              
  Lines        1017     1017              
==========================================
- Hits          882      869      -13     
+ Misses        102      100       -2     
- Partials       33       48      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"UTF-8-SIG" instead of "utf-8", shouldn't we consider that it's basically the same thing, and should we be that strict?

I think that utf-8 is for non-BOM files, since utf-8-bom is for BOM files. If we want to support both, perhaps we allow multiple charsets:

charset = utf-8,utf-8-bom

or maybe

charset = utf-8*

"UTF-8-SIG" instead of "utf-8", shouldn't we consider that it's basically the same thing, and should we be that strict?

I think that utf-8 is for non-BOM files, since utf-8-bom is for BOM files. If we want to support both, perhaps we allow multiple charsets:

charset = utf-8,utf-8-bom

or maybe

charset = utf-8*

I created a separated issue for this: #511 , we might consider that utf-8-bom, sig, etc are "all the same", depending on how strict we want to be.

@ccoVeille @mstruebing We should merge and release this PR rather quickly as it impacts lot of people as shown here: editorconfig-checker/action-editorconfig-checker#236, #511, #509, #505

Yes I agree, the commit messages still needs to be adjusted.

⧗   input: fix(docs): Update changelog
✖   subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]

⧗   input: fix(docs): Remove version 3.5.1 details from CHANGELOG

Removed details for version 3.5.1 from the changelog.
✖   subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]

cc @rasa

Yes I agree, the commit messages still needs to be adjusted.
cc @rasa

Sorry, I have been traveling all day. And sorry for the capitialization.

Yes I agree, the commit messages still needs to be adjusted.
cc @rasa

Sorry, I have been traveling all day. And sorry for the capitialization.

No problem! Thank you for helping fixing the issue quickly after we released the charset check. 😄