fix: empty format in the config file should be treated as Default#448
Merged
theoludwig merged 2 commits intomainfrom Mar 15, 2025
Merged
fix: empty format in the config file should be treated as Default#448theoludwig merged 2 commits intomainfrom
theoludwig merged 2 commits intomainfrom
Conversation
theoludwig
approved these changes
Mar 6, 2025
klaernie
force-pushed
the
empty-format
branch
2 times, most recently
from
f296af0 to
8d8f800
Compare
ccoVeille
approved these changes
Mar 12, 2025
Contributor
ccoVeille
left a comment
ccoVeille
left a comment
There was a problem hiding this comment.
LGTM 👍
One suggestion anyway
Member
Author
|
I would think this is good to merge now. |
Some of our users have an empty Format in their config file - this should be treated as having requested the "default" output format, as it would be when the option is missing entirely. Closes #430
theoludwig
force-pushed
the
empty-format
branch
from
dc9801d to
68e67ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our users have an empty Format in their config file - this should be treated as having requested the "default" output format, as it would be when the option is missing entirely.
Closes #430