fix: improve default excludes#427
Merged
theoludwig merged 3 commits intomainfrom Jan 21, 2025
Merged
Conversation
This was
linked to
issues
Jan 18, 2025
ccoVeille
approved these changes
Jan 18, 2025
Contributor
|
Another common exclude is "vendor" I think |
theoludwig
approved these changes
Jan 19, 2025
Okeanos
added a commit
to Okeanos/template-repository
that referenced
this pull request
Apr 7, 2025
- Git was excluded correctly via editorconfig-checker/editorconfig-checker#427 - make the checker output GH Actions compatible output - invoke it correctly (`.` vs implicit current path has different results/parsing behavior)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After reading through past issues, I came to the conclusion that we should exclude both
.git(#268 ) andnode_modules(#197) by default.