Ignore unrecognized charsets (Fixes #252)#284
Merged
mstruebing merged 1 commit intoeditorconfig-checker:mainfrom Oct 5, 2023
Merged
Ignore unrecognized charsets (Fixes #252)#284mstruebing merged 1 commit intoeditorconfig-checker:mainfrom
mstruebing merged 1 commit intoeditorconfig-checker:mainfrom
Conversation
5 tasks
Member
|
Hey @rasa thank you very much for this PR 🙏 For this, I suggest something like: or if you want to be even a bit more specific: The code itself looks good, if CI passes I will merge and create a new release. |
rasa
force-pushed
the
main
branch
2 times, most recently
from
5a993a7 to
b5546ef
Compare
Contributor
Author
|
@mstruebing Commit message fixed. Sorry 'bout that. |
fixes editorconfig-checker#252 Passes all tests.
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests pass.