Skip to content

Pass an "auto-save" reason to avoid trimming whitespace at the cursor#172

Merged
jednano merged 1 commit intoeditorconfig:masterfrom
dgileadi:trim-trailing-preserve-cursor
Oct 25, 2017
Merged

Pass an "auto-save" reason to avoid trimming whitespace at the cursor#172
jednano merged 1 commit intoeditorconfig:masterfrom
dgileadi:trim-trailing-preserve-cursor

Conversation

@dgileadi
Copy link

@dgileadi dgileadi commented Oct 7, 2017

This fixes #47, but depends on vscode PR #35778 before it will actually do anything. This PR should not be merged until that PR is accepted.

Copy link
Member

@jednano jednano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great job!

@dgileadi
Copy link
Author

The corresponding vscode PR was merged, so this can go in now. There shouldn't be any need to time this fix with the next vscode release, since the extra parameter will be ignored by the current vscode, and is not required by the upcoming release.

@jednano jednano merged commit a7d8304 into editorconfig:master Oct 25, 2017
@dgileadi dgileadi deleted the trim-trailing-preserve-cursor branch October 27, 2017 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trim_trailing_whitespace moves caret

2 participants