Repository navigation
Commit ebd8429
authored
Revert: fix(tool): remove redundant --enable-experiment=record-use flag (flutter#190583)
Reverts: [fix(tool): remove redundant --enable-experiment=record-use
flag](flutter#190475)
Initiated by: @cbracken
Reason for reverting: ```
Original PR Author: @kevmoo
Reviewed By: @mdebbar
The original PR description is provided below:
When compiling web targets (dart2js and dart2wasm) or running dry runs
with the record-use feature flag enabled, flutter_tools explicitly
passed --enable-experiment=record-use to the compiler. Since record-use
is enabled by default in recent Dart SDKs, passing this flag caused
warning spam during standard compilation and dry runs.
* Remove --enable-experiment=record-use from Dart2JSTarget and
Dart2WasmTarget in web.dart.
* Remove expected flag from test commands in web_test.dart and
web_dry_run_test.dart.
Fixes flutter#1904651 parent fa4be6c commit ebd8429
3 files changed
Lines changed: 10 additions & 2 deletions
File tree
- packages/flutter_tools
- lib/src/build_system/targets
- test/general.shard/build_system/targets
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
202 | | - | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
203 | 206 | | |
204 | 207 | | |
205 | 208 | | |
| |||
371 | 374 | | |
372 | 375 | | |
373 | 376 | | |
374 | | - | |
| 377 | + | |
375 | 378 | | |
| 379 | + | |
| 380 | + | |
376 | 381 | | |
377 | 382 | | |
378 | 383 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| 101 | + | |
101 | 102 | | |
102 | 103 | | |
103 | 104 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
| |||
1366 | 1367 | | |
1367 | 1368 | | |
1368 | 1369 | | |
| 1370 | + | |
1369 | 1371 | | |
1370 | 1372 | | |
1371 | 1373 | | |
| |||
0 commit comments