Repository navigation
ci(security): scan PRs automatically instead of manual dispatch - #659
Merged
Merged
Conversation
added 3 commits
October 5, 2026 01:23
Run Security scan on pull_request (opened, synchronize, reopened) so the required scan-result check is produced automatically for every PR instead of requiring a manual workflow_dispatch run from the Actions tab. Intermediate pushes stay cheap thanks to the existing concurrency block (cancel-in-progress): a new commit in a PR cancels the previous scan run; only the latest head SHA gets a full scan. workflow_dispatch is kept for manual re-runs; push to main and the weekly schedule are unchanged. All scan jobs remain on self-hosted runners. Signed-off-by: pirog-spb <[email protected]>
needs.result.build-image is parsed as subtraction (needs.result.build minus image) in GitHub Actions expressions, so every check in the scan-result aggregate substituted an empty string and the job always failed with: if [ "" != "success" ]; then ...; failed=1; fi Use the bracket syntax needs.result['build-image'] instead. Signed-off-by: pirog-spb <[email protected]>
The badge links still referenced trivy.yml, which was replaced by security-scan.yml in #656, so the 'Security' badge in the README went dead. Signed-off-by: pirog-spb <[email protected]>
pirog-spb
added a commit
that referenced
this pull request
Oct 31, 2026
Signed-off-by: pirog-spb <[email protected]> (cherry picked from commit 9062953) Signed-off-by: pirog-spb <[email protected]>
pirog-spb
added a commit
that referenced
this pull request
Oct 31, 2026
Signed-off-by: pirog-spb <[email protected]> (cherry picked from commit 9062953) Signed-off-by: pirog-spb <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run Security scan on pull_request (opened, synchronize, reopened) so the required scan-result check is produced automatically for every PR instead of requiring a manual workflow_dispatch run from the Actions tab.
Intermediate pushes stay cheap thanks to the existing concurrency block (cancel-in-progress): a new commit in a PR cancels the previous scan run; only the latest head SHA gets a full scan.
workflow_dispatch is kept for manual re-runs; push to main and the weekly schedule are unchanged. All scan jobs remain on self-hosted runners.