Repository navigation
ci: fix golangci-lint failing due to Go toolchain mismatch - #651
Merged
Merged
Conversation
added 3 commits
October 3, 2026 14:17
The Test workflow has been failing on the golangci-lint step since February 2026: raw-upf-presetup resolves go-version '>=1.21.0' to the latest Go (1.26.8), while golangci-lint-action@v3 installs golangci-lint v1.x built with Go 1.24. Its typecheck then fails on the Go 1.26 stdlib (fips140only_go1.26.go: file requires newer Go version go1.26) and reports bogus errors in the swag dependency. - Pin Go to go.mod (go-version-file) and bump setup-go v4 -> v5 - Bump golangci-lint-action v3 -> v8 with pinned golangci-lint v2.6.2 - Bump checkout v3 -> v4 Also removes Node.js 20 / EOL action deprecation warnings. Signed-off-by: pirog-spb <[email protected]>
With golangci-lint upgraded to v2.6.2 (previous commit), its stricter defaults flag issues the old v1 version did not report: - errcheck: check or explicitly ignore Close() errors in defers and cleanup paths (main.go, gtp_path_manager.go, objects.go, tests); PfcpConnection.Close now returns the underlying error - staticcheck QF1008: drop redundant embedded IpEntrypointObjects selector in api/rest handlers - staticcheck ST1005: lowercase error strings, drop trailing periods (core) - staticcheck QF1012: use fmt.Fprintf instead of WriteString(fmt.Sprintf(...)) in display helpers - staticcheck QF1003: use a tagged switch on far.Type - staticcheck ST1008: return error as the last argument in DeleteUrr (implementation, interface, callers and mock updated) Verified in a Linux container matching CI (clang/llvm, go generate, golangci-lint v2.6.2): 0 lint issues, build and go test ./cmd/... pass. Signed-off-by: pirog-spb <[email protected]>
…t size from strconv.Atoi to a lower bit size type uint32 without an upper bound check Signed-off-by: pirog-spb <[email protected]>
pirog-spb
added a commit
that referenced
this pull request
Oct 31, 2026
Signed-off-by: pirog-spb <[email protected]> Co-authored-by: pirog-spb <[email protected]> (cherry picked from commit 6f3c030) Signed-off-by: pirog-spb <[email protected]>
pirog-spb
added a commit
that referenced
this pull request
Oct 31, 2026
Signed-off-by: pirog-spb <[email protected]> Co-authored-by: pirog-spb <[email protected]> (cherry picked from commit 6f3c030) Signed-off-by: pirog-spb <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.