Skip to content

fix: ebpf program build warnings - #619

Merged
pirog-spb merged 3 commits into
mainfrom
618-build-warnings-wincompatible-pointer-types-discards-qualifiers
Jun 1, 2025
Merged

pirog-spb merged 3 commits into
mainfrom
618-build-warnings-wincompatible-pointer-types-discards-qualifiers

Conversation

@pirog-spb

@pirog-spb pirog-spb commented May 27, 2025 •

Copy link
Copy Markdown
Collaborator

Use a correct qualifier for function argument in order to fix -Wincompatible-pointer-types-discards-qualifiers.

/git/eupf/cmd/ebpf/xdp/n3n6_entrypoint.c:114:60: warning: passing 'volatile __u64 *' (aka 'volatile unsigned long long *') to parameter of type '__u64 *' (aka 'unsigned long long *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
    if (XDP_DROP == limit_rate_sliding_window(packet_size, &qer->dl_start, qer->dl_maximum_bitrate))
                                                           ^~~~~~~~~~~~~~
./xdp/qer.h:67:98: note: passing argument to parameter 'windows_start' here
static __always_inline enum xdp_action limit_rate_sliding_window(const __u64 packet_size, __u64 *windows_start, const __u64 rate) {
                                                                                                 ^
/git/eupf/cmd/ebpf/xdp/n3n6_entrypoint.c:177:60: warning: passing 'volatile __u64 *' (aka 'volatile unsigned long long *') to parameter of type '__u64 *' (aka 'unsigned long long *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
    if (XDP_DROP == limit_rate_sliding_window(packet_size, &qer->dl_start, qer->dl_maximum_bitrate))
                                                           ^~~~~~~~~~~~~~
./xdp/qer.h:67:98: note: passing argument to parameter 'windows_start' here
static __always_inline enum xdp_action limit_rate_sliding_window(const __u64 packet_size, __u64 *windows_start, const __u64 rate) {
                                                                                                 ^
/git/eupf/cmd/ebpf/xdp/n3n6_entrypoint.c:309:60: warning: passing 'volatile __u64 *' (aka 'volatile unsigned long long *') to parameter of type '__u64 *' (aka 'unsigned long long *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
    if (XDP_DROP == limit_rate_sliding_window(packet_size, &qer->ul_start, qer->ul_maximum_bitrate))
                                                           ^~~~~~~~~~~~~~
./xdp/qer.h:67:98: note: passing argument to parameter 'windows_start' here
static __always_inline enum xdp_action limit_rate_sliding_window(const __u64 packet_size, __u64 *windows_start, const __u64 rate) {
                                                                                                 ^
3 warnings generated.

Signed-off-by: pirog-spb <[email protected]>
@pirog-spb pirog-spb linked an issue May 27, 2025 that may be closed by this pull request
@pirog-spb pirog-spb added this to the v0.8.0 milestone May 27, 2025
pirog-spb added 2 commits May 27, 2025 10:23
Signed-off-by: pirog-spb <[email protected]>
Signed-off-by: pirog-spb <[email protected]>
@pirog-spb
pirog-spb merged commit f1f7abf into main Jun 1, 2025
pirog-spb added a commit that referenced this pull request Oct 31, 2026
Signed-off-by: pirog-spb <[email protected]>
Co-authored-by: pirog-spb <[email protected]>
(cherry picked from commit f1f7abf)
Signed-off-by: pirog-spb <[email protected]>
pirog-spb added a commit that referenced this pull request Oct 31, 2026
Signed-off-by: pirog-spb <[email protected]>
Co-authored-by: pirog-spb <[email protected]>
(cherry picked from commit f1f7abf)
Signed-off-by: pirog-spb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build warnings: Wincompatible-pointer-types-discards-qualifiers

1 participant